Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LE 64-bit in isgenq.c #459

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

ifakhrutdinov
Copy link
Contributor

Proposed changes

Allow LE 64-bit compilations of c/isgenq.c by removing the corresponding #ifdef's and cleaning up the inline asm.

This PR addresses Issue: #422

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Regression testing of the code using isgenq.c is required; specifically, ZIS needs to be tested.

Further comments

@ifakhrutdinov ifakhrutdinov added the enhancement New feature or request label Jun 24, 2024
@ifakhrutdinov ifakhrutdinov requested a review from JoeNemo June 24, 2024 19:58
@ifakhrutdinov ifakhrutdinov self-assigned this Jun 24, 2024
@ifakhrutdinov ifakhrutdinov force-pushed the feature/isgenq-le64 branch 2 times, most recently from 1eb7103 to 5cdcf55 Compare August 21, 2024 07:25
Changes:
* Allow LE 64-bit compilation;
* Use named parameters and registers in __asm.
* Add isgenq tests;
* Improve doc in the isgenq header.

Fixes: #422

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@ifakhrutdinov ifakhrutdinov changed the base branch from v2.x/staging to v3.x/staging August 21, 2024 18:33
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@JoeNemo JoeNemo merged commit 380dfaf into v3.x/staging Aug 22, 2024
1 check passed
@ifakhrutdinov ifakhrutdinov deleted the feature/isgenq-le64 branch August 22, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants